Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-187 Marketo Form Profile Service #188

Closed
wants to merge 5 commits into from
Closed

Conversation

yesil
Copy link

@yesil yesil commented May 12, 2021

Description

Added a new feature to the Marketo component

Related Issue

#187

Motivation and Context

Improve user experience by reducing the number of fields to fill

How Has This Been Tested?

Unit tests + manual tests.

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Documentation:
Marketo.md

import org.apache.sling.models.annotations.DefaultInjectionStrategy;

@Deprecated
@Model(adaptables = SlingHttpServletRequest.class, defaultInjectionStrategy = DefaultInjectionStrategy.OPTIONAL)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to restore this back as Dexter still has dependencies on this.

@yesil
Copy link
Author

yesil commented Jul 6, 2021

@auniverseaway closing this as the internal project is put on hold.

@yesil yesil closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant