ember-data v5.3 #436
Open
ember-data v5.3 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
from
6126e16
to
b0eb346
Compare
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
14 times, most recently
from
a04b28b
to
f54c3c5
Compare
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
2 times, most recently
from
0b7a287
to
8d36e6c
Compare
derrabauke
reviewed
Sep 4, 2024
| .includes(this.user?.get("id")); | ||
| } | ||
|
|
||
| async canAedit() { |
There was a problem hiding this comment.
I think the naming is not ideal. What do you think of canEditAsync? Then it would be more obvious what that thing does.
| const selected = this.selectedReportIds; | ||
|
|
||
| if (selected.includes(report.id)) { | ||
| this.selectedReportIds = A([ |
There was a problem hiding this comment.
I think we could get rid of that A(...), what do you think?
There was a problem hiding this comment.
Naming things 😅 -- What ya think about promise-wrapper?
| import Component from "@glimmer/component"; | ||
| import { dropTask } from "ember-concurrency"; | ||
| import ReportValidations from "timed/validations/report"; | ||
|
|
||
| export default class ReportRowComponent extends Component { | ||
| @service abilities; |
There was a problem hiding this comment.
Shouldn't that stay here? It's used in canEdit
Comment on lines
+2
to
+4
| {{#let (can "edit report" @report) as |syncEditable|}} | ||
| {{#let this.canEdit syncEditable as |promise|}} | ||
| <PromiseThing @await={{not syncEditable}} @promise={{promise}} @value={{syncEditable}} as |t|> |
There was a problem hiding this comment.
See above combination of or (can syncEdit) (can asyncEdit)
There was a problem hiding this comment.
i'd have to await the (can asyncEdit) as it returns a promise
| @@ -212,7 +213,7 @@ export default class ActivitiesIndexController extends Controller { | |||
| data.duration.add(report.get("duration")); | |||
| report.set("duration", data.duration); | |||
| } else { | |||
| report = this.store.createRecord("report", data); | |||
| report = await this.store.createRecord("report", data); | |||
There was a problem hiding this comment.
That's a sync function afaik 🤔
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
2 times, most recently
from
be7b7e2
to
257a350
Compare
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
3 times, most recently
from
c8e5958
to
45287c2
Compare
this changes `ability.canEdit` into 2 parts, `ability.canEdit` which checks if for if you are superuser, if the report hasn't been verified and if the report is your own. the other parts of the ability, checking for reviewer and supervisee have been moved into `ability.canAedit`, which is an async ability. places where this is used first check with `canEdit`, if thats false they `await canAedit(report)`. this is ugly and hacky but it works.
c0rydoras
force-pushed
the
refactor/frontend/data-fetching
branch
from
45287c2
to
bb24fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.