fix(frontend): hide task form after creating new project task #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitanOmar
force-pushed
the
hide-task-form-after-creating-new-project-task
branch
from
cd363e4
to
77fe1aa
Compare
MitanOmar
force-pushed
the
hide-task-form-after-creating-new-project-task
branch
from
77fe1aa
to
d7195aa
Compare
derrabauke
reviewed
Jun 20, 2024
Comment on lines
-83
to
-85
| assert.dom("[data-test-name]").hasValue("FooBar Task 1"); | ||
| assert.dom("[data-test-reference]").hasValue("Reference of FooBar Task 1"); | ||
| assert.dom("[data-test-estimated-time]").hasValue("02:15"); |
There was a problem hiding this comment.
Let's test for this stuff later in the flow. Simply save the inputs and then click on the created task again.
derrabauke
reviewed
Jun 20, 2024
Comment on lines
+144
to
+171
| test("The cancel button will hide the form", async function (assert) { | ||
| await visit("/projects"); | ||
| assert.strictEqual(currentURL(), "/projects"); | ||
|
|
||
| await selectChoose( | ||
| "[data-test-customer-selection]", | ||
| ".ember-power-select-option", | ||
| 0 | ||
| ); | ||
|
|
||
| await selectChoose( | ||
| "[data-test-project-selection]", | ||
| ".ember-power-select-option", | ||
| 0 | ||
| ); | ||
|
|
||
| assert.dom("[data-test-add-task]").exists(); | ||
| assert.dom("[data-test-task-table-row]").doesNotExist(); | ||
|
|
||
| await click("[data-test-add-task]"); | ||
| assert.dom("[data-test-task-form]").exists(); | ||
| assert.dom("[data-test-save]").isDisabled(); | ||
|
|
||
| await click("[data-test-cancel]"); | ||
|
|
||
| assert.dom("[data-test-task-form]").doesNotExist(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
You could cover that in the before mentioned test for the task details. Assert the formerly created input data and after that click cancel and assert that it's closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #44