This repository has been archived by the owner on May 13, 2024. It is now read-only.
Type annotations #1071
Merged
Type annotations #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0rydoras
force-pushed
the
type-annotations
branch
from
e406fd2
to
003ca88
Compare
Closed
c0rydoras
force-pushed
the
type-annotations
branch
2 times, most recently
from
82bb51e
to
1c64877
Compare
hairmare
reviewed
Apr 26, 2024
hairmare
reviewed
Apr 26, 2024
hairmare
reviewed
Apr 26, 2024
winged
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
LGTM, but I think we should not spend too much time adding annotations to existing code. The added value gain is not that great to go over everything and "clean it up" all the way.
It's a good thing when writing new code, and I appreciate you doing it here, but let's not start doing this in all projects ;-)
c0rydoras
force-pushed
the
type-annotations
branch
3 times, most recently
from
4420bf0
to
cd96589
Compare
c0rydoras
force-pushed
the
type-annotations
branch
from
cd96589
to
329d5cf
Compare
|
We could also consider using these: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.