fix: improve toml converter #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhizoome
force-pushed
the
jlf/fix-improve-toml-converter
branch
5 times, most recently
from
cf92b04
to
866f6da
Compare
rhizoome
force-pushed
the
jlf/fix-improve-toml-converter
branch
from
866f6da
to
1f561eb
Compare
|
Note to self and @maria-pw: I will regenerate the tomls in tests/ folder before merging, so they use the improved structure. |
|
LGTM |
maria-pw
approved these changes
May 27, 2024
added 2 commits
May 30, 2024 12:25
it is not perfect and optimized for pyaptly config files, but should be good enough. We also add json as another option.
rhizoome
force-pushed
the
jlf/fix-improve-toml-converter
branch
from
1f561eb
to
b061daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the converter is still not perfect and optimized for pyaptly config files. we will add json as an option, too
reviewers: you can basically ignore the actual toml-generator. It is taken from upstream.