Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow conversion of docx files to pdf using a new convert endpoint #622

Merged
merged 3 commits into from
Aug 3, 2023
Merged

feat: allow conversion of docx files to pdf using a new convert endpoint #622

merged 3 commits into from
Aug 3, 2023

Conversation

StephanH90
Copy link
Contributor

@StephanH90 StephanH90 commented Jul 11, 2023 •
edited
Loading

Adds a new convert endpoint which can be used with a post request to submit a docx file which is then converted to pdf and sent back with the response.

@StephanH90 StephanH90 self-assigned this Jul 11, 2023
@StephanH90 StephanH90 changed the title Feat: allow conversion of docx files to pdf using a new convert endpoint Draft: Feat: allow conversion of docx files to pdf using a new convert endpoint Jul 13, 2023
@StephanH90
Copy link
Contributor Author

StephanH90 commented Jul 13, 2023 •
edited
Loading

there seems to be an issue when im using it in camac, Im investigating.

@StephanH90 StephanH90 changed the title Draft: Feat: allow conversion of docx files to pdf using a new convert endpoint Feat: allow conversion of docx files to pdf using a new convert endpoint Jul 13, 2023
@StephanH90
Copy link
Contributor Author

StephanH90 commented Jul 13, 2023 •
edited
Loading

Turns out that this is failing in the repo that I tried to use it in because the group attribute on the template was removed and the consuming application still tries to write this. So, it isn't an issue with this MR.

winged
winged requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like!

Just figured that we shouldn't limit ourselves too much on the input formats

document_merge_service/api/views.py Outdated Show resolved Hide resolved
@StephanH90 StephanH90 requested a review from winged August 2, 2023 14:56
@StephanH90 StephanH90 changed the title Feat: allow conversion of docx files to pdf using a new convert endpoint feat: allow conversion of docx files to pdf using a new convert endpoint Aug 2, 2023
@StephanH90 StephanH90 force-pushed the feat/file-conversion branch 2 times, most recently from 0ed7793 to f3561dd Compare August 2, 2023 15:22
@StephanH90 StephanH90 merged commit fcb9d7a into adfinis:main Aug 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

@open-dynaMIX open-dynaMIX Awaiting requested review from open-dynaMIX

Assignees

@StephanH90 StephanH90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephanH90 @winged