Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add django storages and settings for s3 storage #617

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jun 30, 2023

No description provided.

Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM - Maybe a bit of docs in CONFIGURATION.md tho?

@Yelinz
Copy link
Member Author

Yelinz commented Jul 5, 2023

Added to configuration

@Yelinz Yelinz requested a review from winged July 7, 2023 11:50
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! Just some suggestions on improving the docs

CONFIGURATION.md Outdated Show resolved Hide resolved
@Yelinz Yelinz merged commit e800d41 into adfinis:main Jul 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants