-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add a radius bin to the grid #3662
Open
CarloVarni
wants to merge
6
commits into
acts-project:main
Choose a base branch
from
CarloVarni:AddReadiuBinToGrid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+55
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloVarni
changed the title
feat!: Add a readius bin to the grid
feat!: Add a radius bin to the grid
Sep 29, 2024
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Seeding
Track Finding
labels
Sep 29, 2024
Quality Gate failedFailed conditions |
Can you check if this has runtime performance effects even if configured to behave as before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Seeding
Track Finding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a radius bin to the grid. The binning can be provided by the user with a vector of values. If none is provided, the range
rMin -> rMax
will be used.That means that now the grids is 3D :
(phi, z, radius)
By default
rMin = 0_mm
, whilerMax = 320_mm