Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add a radius bin to the grid #3662

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CarloVarni
Copy link
Collaborator

This adds a radius bin to the grid. The binning can be provided by the user with a vector of values. If none is provided, the range rMin -> rMax will be used.
That means that now the grids is 3D : (phi, z, radius)

By default rMin = 0_mm, while rMax = 320_mm

@CarloVarni CarloVarni changed the title feat!: Add a readius bin to the grid feat!: Add a radius bin to the grid Sep 29, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding Track Finding labels Sep 29, 2024
@CarloVarni CarloVarni added this to the next milestone Sep 29, 2024
Copy link

📊: Physics performance monitoring for 655341f

Full contents

physmon summary

Copy link

sonarcloud bot commented Sep 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@paulgessinger
Copy link
Member

Can you check if this has runtime performance effects even if configured to behave as before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants