feat: Conversion and chain code in traccc #3656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little weekend gift for @asalzburger |
github-actions
bot
added
Infrastructure
stephenswat
force-pushed
the
feat/traccc_host
branch
4 times, most recently
from
cebf42a
to
ba45053
Compare
stephenswat
force-pushed
the
feat/traccc_host
branch
2 times, most recently
from
cd6a697
to
ea15a01
Compare
|
|
|
||
| auto traccc = mex.def_submodule("traccc"); | ||
| auto [_, mex] = ctx.get("main", "examples"); | ||
| auto m = mex.def_submodule("_traccc"); |
There was a problem hiding this comment.
Does this run the code that adds a submodule multiple times?
There was a problem hiding this comment.
We anyway need to streamline a bit the python bindings and make it somewhat consistent.
At this point in time, the iterator for `MeasurementContainer` does not match the `std::forward_iterator` concept which SonarCloud really wants me to use. In this commit, I make sure that the iterator satisfies the concept. Unfortunately, this requires a default-initializer, because `std::forward_iterator` requires `std::incrementable` which requires `std::regular`, which requires `std::semiregular` which in turn requires `std::default_initializable` which I think is silly.
stephenswat
force-pushed
the
feat/traccc_host
branch
from
ea15a01
to
a0c9c25
Compare
This PR adds conversion code as well as the code to run simple host-side chain algorithms using traccc. Co-authored-by: Stephen Nicholas Swatman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conversion code as well as the code to run simple host-side chain algorithms using traccc.
This code is highly experimental and perhaps not yet of the highest possible quality; I intend to iterate on this later, but I'd like to get the skeleton in to somewhat stabilize this plugin.
Closes #3281, #3320, #3363, #3505.