fix(gx2f): new error UsedUnreachableMeasurements

[AJPfleger]

This fixes a super rare bug. 1 in 17k segfaulted at calculateTrackQuantities(track). This was, because the tipIndex was set outside the actual track. The wrong tipIndex comes from the last propagation where we didn't try to hit all inputMeasurements on insertExternalSurfaces.

The created track contains measurement information, that is missing in the final track. We could think about having this as an outlier or refit ignoring the missed measurements. For now, I would just return an error, because:

• We have no proper outlier definition in the GX2F yet
• Refitting should be maybe a user-task. The whole refitting logic with a dropped measurement might make the whole fitter quite complicated
• The error is so rare, that it is fine, to just avoid crashing

We discussed an would refrain from creating a unit test, since it is quite difficult to reproduce this edge case in an isolated environment. Due to its rarity, it might be not worth the time.

[github-actions]

📊: Physics performance monitoring for 66b8069

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
29.9% Coverage on New Code
55.3% Duplication on New Code

See analysis details on SonarCloud