-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCH 6790 3.4.x : Port maintenance mode changes #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test coverage. Looks fine
/** | ||
* Returned when the service is intentionally configured to be in maintenance. | ||
*/ | ||
public const SERVICE_UNDER_MAINTENANCE = 503; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the wrong maintenance code @narendradesai @kirtigarg2584
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is supposed to be 5031
This PR needs to be reopened @kirtigarg2584 |
@saxumVermes @kirtigarg2584 Created PR to update maintenance mode code: #190 |
Motivation
Fixes #NNN
Proposed changes
Alternatives considered
Testing steps