Added typing hints to dark/process.py. Added a test to windowedIdentity. #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imLew
approved these changes
Oct 18, 2024
Comment on lines
+32
to
+33
| @property | ||
| def dryRun(self) -> bool: |
There was a problem hiding this comment.
You say my properties are idiosyncratic... why do you keep this method as a property that just returns an attribute?
Comment on lines
+46
to
+47
| stdout: Optional[Union[bool, TextIO, StringIO]] = False, | ||
| stderr: Optional[Union[bool, TextIO, StringIO]] = False, |
There was a problem hiding this comment.
I would remove the bool and change the default to None, it seems unnecessary to have two false-y values meaning the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.