-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for staggered grid #270
Open
bpappin
wants to merge
20
commits into
aclassen:main
Choose a base branch
from
bpappin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggingItemTop` values are used in composition
…, refactored onDragStart detection
will someone merge this? |
Please merge this @aclassen |
For those needing this, it looks like its been added for 0.9.7, but the PR not merged. |
Fix infinite recomposition happening when `draggingItemLeft` and `dra…
* main: Fix infinite recomposition happening when `draggingItemLeft` and `draggingItemTop` values are used in composition
…92/ComposeReorderable into VeselyJan92-compose_gradle_upgrade # Conflicts: # android/build.gradle.kts # build.gradle.kts # gradle.properties # gradle/wrapper/gradle-wrapper.properties
…ctored_forEachGesture_with_awaitEachGesture Merging PR with conflicts.
Add onDragStart callback
0.9.7_INTERIM
…develop * 'develop' of github.com:bpappin/ComposeReorderable: Add onDragStart callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal structure of LazyStaggeredGridItemScope is missing the animateItemPlacement() modifier that LazyGridItemScope has, so that section does not work properly.
Also, there was no way to tell the orientation from LazyStaggeredGridState.isVertical because its internal and not accessible, which lead to separate remember clauses.