Skip to content

Commit

Permalink
minor changes
Browse files Browse the repository at this point in the history
  • Loading branch information
mauro-milella committed Jul 5, 2023
1 parent 70ed0fc commit 077f8dc
Showing 1 changed file with 30 additions and 35 deletions.
65 changes: 30 additions & 35 deletions NOTE → NOTES
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
The following file is just a scratchpad, and can be ignored.

<!-- Draft README.md
# Usage

Expand Down Expand Up @@ -33,48 +35,41 @@ Finally, pairing each world in the Kripke frame with a list of propositional let

-->

-------------------------------------------------------------------------------------------

propositional-logic:

julia> t2 = TruthDict(["a" => true, "b" => false, "c" => true])
TruthDict wrapping:
Dict{Proposition{String}, Bool} with 3 entries:
Proposition{String}("c") => 1
Proposition{String}("b") => 0
Proposition{String}("a") => 1

1) rename TruthDict in TruthTable
then, change

function Base.show(
io::IO,
i::TruthDict{A,T,D},
) where {A,T<:TruthValue,D<:AbstractDict{<:Proposition{<:A},T}}
# println(io, "TruthDict{$(A),$(T),$(D)} wrapping:")
println(io, "TruthDict wrapping:")
Base.display(i.truth)
end
syntaxstring:

to be
DONE: 0) clone, instantiate and checkout in dev-v0.9.1 the following packages: SoleBase, SoleData.

" | p | q | r | s | "
DONE: 1) rename parentheses in parentheses, and parenthesis in paranthesis.

-------------------------------------------------------------------------------------------
2) make syntaxstring more readable (by default, not all parentheses are displayed.)
2.1) optional parameter "allparentheses"
2.2) testing both with allparantheses=false (default) and true)

syntaxstring:
3) propositional-logic:
julia> t2 = TruthDict(["a" => true, "b" => false, "c" => true])
TruthDict wrapping:
Dict{Proposition{String}, Bool} with 3 entries:
Proposition{String}("c") => 1
Proposition{String}("b") => 0
Proposition{String}("a") => 1

DONE: 0) clonare e istanziare in dev-v0.9.1 (e tenerlo checkouttato lì) SoleBase e SoleData.
* rename TruthDict in TruthTable
then, change

1) rinominare parentheses in parentheses, e parenthesis in paranthesis.
Questo va fatto in SoleLogics (dev-v0.9.1), e SoleModels (dev-v0.9.1)
function Base.show(
io::IO,
i::TruthDict{A,T,D},
) where {A,T<:TruthValue,D<:AbstractDict{<:Proposition{<:A},T}}
# println(io, "TruthDict{$(A),$(T),$(D)} wrapping:")
println(io, "TruthDict wrapping:")
Base.display(i.truth)
end

2) rendere più leggibile syntaxstring (di default, NON è allparentheses.)
2.1) scegliere con parametro "allparentheses"
2.2) TESTARE (cioè, vedere che i test girino già come sono adesso)
2.3) testare anche, ovviamente, con allparentheses=true
to be

3) vedi propositional-logic sopra
" | p | q | r | s | "

4) Leggere documentazione SoleData (controllare anche grammatica) e vedere se ho capito
e cosa trasporterei in SoleLogics.
4.1) Eventualmente fare un branch personale
4) Read SoleData documentation
4.1) Eventually, make a custom branch

0 comments on commit 077f8dc

Please sign in to comment.