Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoof newer Touchpad for Sequoia #26

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Conversation

1Revenger1
Copy link
Contributor

@1Revenger1 1Revenger1 commented Jun 12, 2024

Spoofs a newer touchpad. macOS Sequoia dropped the IOKit personalities for the older SPI touchpads, including the one used by VoodooInput.

macOS Sequoia dropped the IOKit personalities for all the SPI touchpads, including the one used by VoodooInput.
@Edwardwich

This comment was marked as spam.

@stevezhengshiqi
Copy link

Just raise a concern if 0x265 still works in Recovery mode, which was a problem years ago before VoodooI2C/VoodooI2C@3f00f01. So sorry that I can't test this due to my broken hack.

@vit9696
Copy link
Collaborator

vit9696 commented Jun 12, 2024

Is it possible this breaks older macOS?

@1Revenger1
Copy link
Contributor Author

@kprinssu

Catalina recovery seemed to work just fine but I have no clue about older macOS recovery installs. I also don't think this would break older macOS version as the MT2 was introduced around 10.11.

I can go ahead and try to find a newer touchpad product ID though and switch it based off of version. That way we use an embedded touchpad product ID instead of an external USB/BT one.

@kprinssu
Copy link
Collaborator

@1Revenger1 The change looks good. If you can address @stevezhengshiqi and @vit9696's comments, then I am good with this PR.

@1Revenger1
Copy link
Contributor Author

I changed it to use internal touchpads instead of the MT2. This should keep the old behavior for older OSes.

@1Revenger1 1Revenger1 changed the title Use Magic Trackpad 2 Product ID Spoof newer Touchpad for Sequoia Jun 12, 2024
Copy link
Collaborator

@kprinssu kprinssu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @vit9696's thoughts on this, but this is good by me.

@vedantmgoyal9
Copy link

I built kexts with both 0x265 and 0x281 IDs, and got slightly smoother performance when using 0x265, and there were some random pointer movements when using 0x281. Is this behavior expected? Or, there may be some problem with my laptop's trackpad/it must be a one-off thing that happened to me 🤔

If anyone wants, the kexts can be found in the workflow artifacts - https://github.com/vedantmgoyal9/VoodooInput/actions

@kprinssu
Copy link
Collaborator

I built kexts with both 0x265 and 0x281 IDs, and got slightly smoother performance when using 0x265, and there were some random pointer movements when using 0x281. Is this behavior expected? Or, there may be some problem with my laptop's trackpad/it must be a one-off thing that happened to me 🤔

If anyone wants, the kexts can be found in the workflow artifacts - https://github.com/vedantmgoyal9/VoodooInput/actions

It should make no difference. The underlying code is still the same, unless you can measure (say CPU load or some other metric), this is more than likely a placebo.

@Zyvoxi
Copy link

Zyvoxi commented Jun 18, 2024

The VoodooInput with ID 0x281 is superior to VoodooInput 1.1.4(ID 0x272). On Windows, my touchpad operates at a polling rate of 60Hz. On Sonoma, with VoodooInput 1.1.4(ID 0x272), the polling rate is 30Hz. However, with this VoodooInput using ID 0x281 on Sequoia, the polling rate is 60Hz. There isn't a very noticeable difference in usage, but it is an improvement.

@acidanthera acidanthera deleted a comment from Edwardwich Jul 4, 2024
@acidanthera acidanthera locked and limited conversation to collaborators Jul 4, 2024
@acidanthera acidanthera unlocked this conversation Jul 4, 2024
@vit9696
Copy link
Collaborator

vit9696 commented Jul 7, 2024

MacBookAir10,1 was released with macOS 11.x. Since they had a special macOS build, we can assume macOS 12.x as a first fully supported version. Why not to switch to switch to MacBookAir10,1 ID on macOS 12.x and newer instead of macOS 14.x and newer? Otherwise no objections.

VoodooInput/VoodooInput.cpp Outdated Show resolved Hide resolved
@vit9696 vit9696 merged commit f8f8b65 into acidanthera:master Jul 13, 2024
3 checks passed
@acidanthera acidanthera locked and limited conversation to collaborators Jul 13, 2024
@1Revenger1 1Revenger1 deleted the Sequoia branch July 13, 2024 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants