-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Editor) Cursor Inconsistency and edit lost fix in monaco editor #95
Merged
dselman
merged 1 commit into
accordproject:main
from
nitro56565:nitro56565/i95/inconsistent-cursor-movement
Aug 5, 2024
Merged
fix(Editor) Cursor Inconsistency and edit lost fix in monaco editor #95
dselman
merged 1 commit into
accordproject:main
from
nitro56565:nitro56565/i95/inconsistent-cursor-movement
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahesh Patil <[email protected]>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dselman can you please review the code |
nitro56565
changed the title
cursor inconsistency in editor fixed
Fix(Editor)cursor inconsistency in editor fixed
Aug 3, 2024
nitro56565
changed the title
Fix(Editor)cursor inconsistency in editor fixed
fix(Editor) Cursor Inconsistency and edit lost fix in monaco editor
Aug 3, 2024
dselman
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Vinyl-Davyl
pushed a commit
to Vinyl-Davyl/template-playground
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Mahesh Patil <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Vinyl-Davyl
pushed a commit
to Vinyl-Davyl/template-playground
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Mahesh Patil <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
sanketshevkar
pushed a commit
that referenced
this pull request
Sep 3, 2024
* cursor inconsistency in editor fixed (#95) Signed-off-by: Mahesh Patil <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update(ui): secondary theme color (#93) * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> --------- Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * chore(doc): doc updated with recent project feature (#92) * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> --------- Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * chore: updated contents Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> --------- Signed-off-by: Mahesh Patil <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Co-authored-by: Mahesh Patil <[email protected]>
sanketshevkar
pushed a commit
that referenced
this pull request
Sep 3, 2024
* update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * cursor inconsistency in editor fixed (#95) Signed-off-by: Mahesh Patil <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update(ui): secondary theme color (#93) * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> --------- Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development (#97) Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> * update: development Signed-off-by: Vinyl-Davyl <[email protected]> --------- Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Mahesh Patil <[email protected]> Co-authored-by: Mahesh Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Description
The Monaco editor were experiencing cursor jumping issues and edit lost when updating state using Zustand. The cursor would jump to the top or bottom of the editor, causing a poor user experience. This issue was identified as a result of state updates causing unnecessary re-renders.
Solution
Changes Made (TemplateMarkdown, TemplateModel and AgreementData)
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname