Port defadvice to define-advice #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Emacs 30.1, `defadvice` has been marked obselete, and can lead to byte-compilation errors. Luckily, this is easy to fix; all we need to do is to replace invocations of `defadvice` with `define-advice`. This also comes with some other minor benefits: we can remove the surrounding `eval-after-load 'find-func` from our advice, as `define-advice` can be used to advise functions that are not yet been defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Emacs 30.1,
defadvicehas been marked obselete, and can lead to byte-compilation errors. Luckily, this is easy to fix; all we need to do is to replace invocations ofdefadvicewithdefine-advice.This also comes with some other minor benefits: we can remove the surrounding
eval-after-load 'find-funcfrom our advice, asdefine-advicecan be used to advise functions that are not yet been defined.