Do not call fundamental-mode if lv buffer is already in fundamental-mode #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually calling the fundamental-mode function can be a bit slow, because it involves running change-major-mode-hook and also doing a mode-line redisplay. When the lv buffer is re-created over and over, this can contribute to significant visual stuttering. For example, in Spacemacs, pressing SPC w . (window transient state) and then holding down } (enlarge) lags heavily before this change, but is much smoother after. Preserve the behavior of abo-abo#364, however, to ensure that the lv buffer is still in the correct major-mode.
|
This change seems to be a definite improvement and would be great to see merged. It does make a difference on my system, though the example of resizing windows in Spacemacs still stutters quite a bit for me. This is probably due to a combination of a relatively old CPU, a high key repeat rate, and non-trivial members in the relevant hooks. I had investigated the same underlying performance problem with the scroll transient state in Spacemacs and came up with this workaround: #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually calling the fundamental-mode function can be a bit slow,
because it involves running change-major-mode-hook and also doing a
mode-line redisplay. When the lv buffer is re-created over and
over, this can contribute to significant visual stuttering.
For example, in Spacemacs, pressing SPC w . (window transient state)
and then holding down } (enlarge) lags heavily before this change, but
is much smoother after.
Preserve the behavior of #364, however, to ensure that the lv buffer
is still in the correct major-mode.