Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ace-window-hook #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ace-window-hook #77

wants to merge 1 commit into from

Conversation

aborn
Copy link

@aborn aborn commented Sep 22, 2016

No description provided.

@abo-abo
Copy link
Owner

abo-abo commented Sep 23, 2016

What good can this hook serve?

@shackra
Copy link

shackra commented Sep 28, 2016

turning of golden-ratio-mode for a while and other stuff, maybe?

@abo-abo
Copy link
Owner

abo-abo commented Sep 28, 2016

What's wrong with using this in your own config:

(defun ace-window-after-hook (arg)
  (message "ace-window %d" arg))

(advice-add 'ace-window :after #'ace-window-after-hook)
;; (advice-remove 'ace-window #'ace-window-after-hook)

Compared to the hook solution, it's just one line more in the user's config. But:

  • It's 0 lines in my package, which means it's easier to use and understand.
  • It's more flexible in the user's config: you can redefine the advice to :before or :around etc.

@shackra
Copy link

shackra commented Sep 29, 2016

I guess there is nothing wrong...

El miércoles 28 de septiembre del 2016 a las 1020 horas, Oleh Krehel escribió:

What's wrong with using this in your own config:

(defun ace-window-after-hook (arg)
  (message "ace-window %d" arg))

(advice-add 'ace-window :after #'ace-window-after-hook)
;; (advice-remove 'ace-window #'ace-window-after-hook)

Compared to the hook solution, it's just one line more in the user's config. But:

  • It's 0 lines in my package, which means it's easier to use and understand.
  • It's more flexible in the user's config: you can redefine the advice to :before or :around etc.

👋 Pax et bonum.
Jorge Araya Navarro
https://es.gravatar.com/shackra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants