Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example apps testflight continuous delivery #483

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

JakubJankowski
Copy link
Contributor

@JakubJankowski JakubJankowski commented Dec 5, 2022

In case I won't be able to finish work on this PR before my holidays here is what needs to be done for this PR to be ready for review:
We're mainly waiting for the IT team to create an App Store Connect user that we will use to auth with App Store Connect in the upload_to_testflight step in two Fastfiles: both for the PublisherExampleSwiftUI and Subscriber Example apps.

  • We'll need to add a new github Secret - APPLE_APPS_USERNAME, which will contain the email of the App Store Connect user
  • We'll need to create a new App Specific Password for this user: https://support.apple.com/en-us/HT204397, and then replace the github secret's value for: APPLE_APPS_APPLICATION_SPECIFIC_PASSWORD with this password. Inn testflight.yml We make a FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD ENV from it, which is automatically detected and used by Fastlane during the upload_to_testflight step.
  • Currently, testflight.yml is set to run on pull_request: for testing purposes. Once this whole flow is finally tested and it works fine, it should be set to run only when code is pushed to the main branch, so pull_request: bit needs to be removed.

Additional considerations:

  • I'm not sure if we actually have an AMPLIFY_CONFIGURATION secret added (used in testflight.yml). I've used it in a similar way as it's used in the assemble.yml workflow, but that workflow doesn't even create a JSON file or use this created ENV in any way. So we need to double check if everything is fine here.

@JakubJankowski JakubJankowski self-assigned this Dec 5, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 5, 2022 10:12 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch 8 times, most recently from 33516ab to 2c357fd Compare December 5, 2022 11:44
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 5, 2022 11:58 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch 2 times, most recently from 14f082e to cb794f4 Compare December 5, 2022 13:30
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 5, 2022 13:44 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch 9 times, most recently from bc82338 to ad18e13 Compare December 5, 2022 22:07
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from 8b0af7d to 2c16f8b Compare December 7, 2022 10:19
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 7, 2022 10:34 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from 2c16f8b to 3dd9617 Compare December 7, 2022 10:37
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 7, 2022 10:54 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch 2 times, most recently from 0d49556 to 1b43e26 Compare December 7, 2022 11:52
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 7, 2022 12:05 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from 1b43e26 to 213914b Compare December 7, 2022 12:14
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 7, 2022 12:31 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from c7c4a0e to fce1272 Compare December 8, 2022 12:17
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 8, 2022 12:34 Inactive
…me minor improvements to the SubscriberExample's Fastfile
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from fce1272 to 380453e Compare December 8, 2022 14:21
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 8, 2022 14:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 9, 2022 11:55 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from 270f64f to ffc7de2 Compare December 12, 2022 09:10
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 12, 2022 09:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/483/jazzy December 12, 2022 14:17 Inactive
@JakubJankowski JakubJankowski force-pushed the example-apps-testflight-continuous-delivery branch from f56a9e1 to c1f684e Compare December 12, 2022 14:24
…ly create the amplifyConfiguration.json file from the ENV
@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 14, 2022

@QuintinWillison as mentioned in standup, I'm assigning this one to you until the Apple ID is set up. Please assign to me afterwards, thanks!

@QuintinWillison QuintinWillison removed their assignment Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Configure github actions for automatic deliveries of example apps to TestFlight
3 participants