Feat/repay wrapper #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foodaka
commented
Oct 7, 2024
foodaka
commented
- Adds repay and repaywithpermit wrapper functionality
|
miguelmtzinf
reviewed
Oct 8, 2024
| require(amountWrapped > 0, 'INSUFFICIENT_WRAPPED_TOKEN_RECEIVED'); | ||
|
|
||
| SafeERC20.safeApprove(IERC20(TOKEN_OUT), address(POOL), amountWrapped); | ||
| POOL.repay(TOKEN_OUT, amountWrapped, 2, onBehalfOf); |
There was a problem hiding this comment.
Suggested change
| POOL.repay(TOKEN_OUT, amountWrapped, 2, onBehalfOf); | |
| POOL.repay(TOKEN_OUT, amountWrapped, VARIABLE_INTEREST_RATE_MODE, onBehalfOf); |
miguelmtzinf
reviewed
Oct 8, 2024
| @@ -240,6 +269,23 @@ abstract contract BaseTokenWrapper is Ownable, IBaseTokenWrapper { | |||
| IERC20(TOKEN_IN).transfer(onBehalfOf, amountIn); | |||
| } | |||
|
|
|||
| function _repayToken( | |||
| uint256 amount, | |||
There was a problem hiding this comment.
we need to handle max repayment here
There was a problem hiding this comment.
so retrieve the outstanding debt of the user, and repay all if amount is higher.
we must do the same thing for withdraw
miguelmtzinf
reviewed
Oct 8, 2024
| @@ -878,11 +878,16 @@ abstract contract BaseTokenWrapperTest is Test { | |||
| } | |||
| } | |||
|
|
|||
| function testFuzzBorrowToken(uint256 borrowAmount) public { | |||
| function testFuzzRepayToken( | |||
There was a problem hiding this comment.
you are replacing testFuzzBorrowToken test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.