Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USDS-SUSDS token wrappers #13

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add USDS-SUSDS token wrappers #13

wants to merge 29 commits into from

Conversation

foodaka
Copy link

@foodaka foodaka commented Sep 18, 2024

Adds wrapper functions for USDS and SUSDS

@height Height
Copy link

height bot commented Sep 18, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@miguelmtzinf miguelmtzinf mentioned this pull request Sep 24, 2024
Closed
@miguelmtzinf miguelmtzinf changed the title WIP: Feat/susds wrappers Add USDS-SUSDS token wrappers Sep 24, 2024
@miguelmtzinf
Copy link
Contributor

Closes #18

CheyenneAtapour and others added 13 commits September 26, 2024 09:23
@CheyenneAtapour
fix: Address pr comments
1ab43a0
@CheyenneAtapour
fix: Move borrow logic to base wrapper
4f5f382
@miguelmtzinf
fix: Move dependencies to V3 origin (#16)
1886062 
* fix: Move dependencies to V3 origin

* fix: Update aave address book dep

* fix: Fix remappings

* fix: remove old version

* fix: Fix dep
@miguelmtzinf
fix: Remove unlimited allowance (#17)
9d654dd
@CheyenneAtapour
feat: Generic ERC4626 <> ERC20 Token Wrapper (#20)
253000b 
* wip: Testing list new asset

* fix: Deploy tokens after setup

* wip: Borrow token test passes

* fix: Use correct aToken address

* fix: Use erc20 permit for mock token

* fix: Remove unused code

* fix: Cleanup and clarifications

* fix: Address pr comments

* fix: Remove redundant dependencies

* fix: Remove max approval and reset approvals on generic wrapper

* test: Add back generic 4626 wrapper test

* fix: Remove unused imports

* fix: Generalize comment

* fix: Remove usds wrapper, use address book
@miguelmtzinf
fix: Remove unneccesary file
53c52bd
@miguelmtzinf
fix: Disables supply with permit for DAI because DAI permit is not st…
37e17c4 
…andard
@miguelmtzinf
fix: Re-order functions based on solidity guideliens
a10494c
@miguelmtzinf
fix: Remove solc warnings
11c19c8
@miguelmtzinf
Refactors tests (#21)
596d521 
* fix: Refactor tests and clean ups

* fix: Move dependencies to external dir
@CheyenneAtapour
test: Add fuzz test for borrow
86fb6e2
@CheyenneAtapour
fix: Revert change test name
9118be9
@CheyenneAtapour
Add Additional BorrowToken Tests (#22)
13224ae 
* test: Add zero amount borrow and permit deadline expired

* test: Test borrowing more than underlying asset in vault

* test: Insufficient collateral and delegation tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheyenneAtapour CheyenneAtapour CheyenneAtapour left review comments

@miguelmtzinf miguelmtzinf miguelmtzinf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foodaka @miguelmtzinf @CheyenneAtapour