feat/ui-stake-helpers #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to 1 task:
|
miguelmtzinf
reviewed
Aug 8, 2023
miguelmtzinf
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Clarify the format and unit denomination of oracles on every @param please.
| * @param stakedTokens An array of addresses representing the staked tokens. | ||
| * @param oracleAddresses An array of addresses representing the oracles associated with the staked tokens. | ||
| * @return stakedData An array containing data about the staked assets. | ||
| * @return prices An array containing the latest price data from the oracles for the staked tokens. |
There was a problem hiding this comment.
why is this array needed? stakedData contains the price of the reward already iirc
|
Link T-13575 |
|
This will also impact the aave utilities, and the frontend integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.