Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array this.traceIndices directly in Plotly.restyle(), avoiding fo… #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bab9e9
Copy link

@bab9e9 bab9e9 commented May 20, 2020

Avoid for loop overhead by passing this.traceIndices to Plotly.restyle

There is no need to send each index separately as [i]. Let Plotly do the work.

@netlify
Copy link

netlify bot commented May 20, 2020

Deploy preview for frosty-benz-8c81bf ready!

Built without sensitive environment variables with commit 034d013

https://deploy-preview-192--frosty-benz-8c81bf.netlify.app

@MrSpiffyClean
Copy link
Contributor

Disregarding the typo npm caught, I don't see anything wrong with this, from a functional point. Someone with more knowledge regarding Plotly might chip in their opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants