Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix | Tags with 0 posts #256

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Bugfix | Tags with 0 posts #256

merged 2 commits into from
Jul 24, 2024

Conversation

vverma022
Copy link
Contributor

@vverma022 vverma022 commented Jul 21, 2024 •
edited
Loading

Pull Request Title

Tags with 0 posts

Description

To make sure when fetching the tags from the backed only the tags with at least 1 post is sent and not all.

Linked Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Changes

  • On the tag-router get('/') route I have added a where query which checks for tagsOnPost

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there are no similar/duplicate pull requests regarding the same issue
  • My changes follow the project's coding guidelines and best practices
  • Code is formatted properly and lint check passes successfully
  • I have made corresponding changes to the documentation (if applicable)

@vercel Vercel
Copy link

vercel bot commented Jul 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medium-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 5:50pm

@aadeshkulkarni aadeshkulkarni changed the title Fixes #241 Bugfix | Tags with 0 posts Jul 21, 2024
@aadeshkulkarni
Copy link
Owner

Thank you for your contribution!

@aadeshkulkarni aadeshkulkarni merged commit 8bf3cd1 into aadeshkulkarni:master Jul 24, 2024
2 checks passed
@vverma022 vverma022 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadeshkulkarni aadeshkulkarni aadeshkulkarni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug | Topics with 0 posts
2 participants
@vverma022 @aadeshkulkarni