fix: using href="#*" spamming browser history when switching translat…

…ion tab (#390)
a2lix · Apr 9, 2024 · 7c0a3a1 · 7c0a3a1
1 parent bc599c5
commit 7c0a3a1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/Resources/views/bootstrap_4_layout.html.twig b/src/Resources/views/bootstrap_4_layout.html.twig
@@ -7,11 +7,11 @@
             {% set locale = translationsFields.vars.name %}
 
             <li class="nav-item">
-                <a href="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
+                <div data-target="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
                     {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                     {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                     {% if translationsFields.vars.required %}*{% endif %}
-                </a>
+                </div>
             </li>
         {% endfor %}
         </ul>

diff --git a/src/Resources/views/bootstrap_5_layout.html.twig b/src/Resources/views/bootstrap_5_layout.html.twig
@@ -7,11 +7,11 @@
             {% set locale = translationsFields.vars.name %}
 
             <li class="nav-item">
-                <a href="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
+                <div data-bs-target="#{{ translationsFields.vars.id }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
                     {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                     {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                     {% if translationsFields.vars.required %}*{% endif %}
-                </a>
+                </div>
             </li>
         {% endfor %}
         </ul>

diff --git a/src/Resources/views/macros_bootstrap_4.html.twig b/src/Resources/views/macros_bootstrap_4.html.twig
@@ -14,11 +14,11 @@ Example:
                 {% set locale = translationsFields.vars.name %}
 
                 <li class="nav-item">
-                    <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
+                    <div data-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>

diff --git a/src/Resources/views/macros_bootstrap_5.html.twig b/src/Resources/views/macros_bootstrap_5.html.twig
@@ -14,11 +14,11 @@ Example:
                 {% set locale = translationsFields.vars.name %}
 
                 <li class="nav-item">
-                    <a href="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
+                    <div data-bs-target="#{{ translationsFields.vars.id }}_{{ fieldsNames|join('_') }}_a2lix_translations-fields" class="nav-link {% if app.request.locale == locale %}active{% endif %}" data-bs-toggle="tab" role="tab">
                         {{ translationsFields.vars.label|default(locale|humanize)|trans }}
                         {% if form.vars.default_locale == locale %}{{ '[Default]'|trans }}{% endif %}
                         {% if translationsFields.vars.required %}*{% endif %}
-                    </a>
+                    </div>
                 </li>
             {% endfor %}
         </ul>