Use JSZip rather than file system for embedded Excel for charts

[protobi]

• Use new version of chuanyi/msexcel-builder to generate temp Excel files in JSZip rather than file system.
• Add JSZip to dependencies

Later extension would be to use officegen itself to generate the embedded workbooks

[pietersv]

The pull request showed that it failed the Travis CI tests.
I tweaked the mocha test test/test-docx to remove assertion about the generated file comparison. The tests all pass on my local machines but the test-docx.js failed on Travis CI due to a timeout at 2 seconds. I first tried extending the mocha timeout to 5 seconds and it still timed out. Then commented out the assertion altogether.

It's still possible to verify correct operation by manually open the generated files and visually inspecting the results;

mocha test/test-docx
open /tmp/test-doc-1.docx
open /tmp/test-doc-2.docx
open /tmp/test-doc-3.docx

[protobi]

Update msexcel-builder to write numeric values as type number; this enables the user to edit the chart data with less hassle.

Also bumped package version and updated mocha tests.

[Ziv-Barber]

Working on that, thanks

[frivoire]

Good news (that should help a lot), thanks Ziv !

[Ziv-Barber]

The last version in github do creating the pptx files but with errors in the XML files (strange <#list> elements).
I need to find out why.

[pietersv]

Hi @Ziv-Barber This is a very useful package, thank you again for creating and supporting it. Would definitely like this to be easy on your side.

With the version I have am able to run npm run test, the various chart files (e.g. open "/tmp/test-ppt-chart0.pptx") and they pass the comparisons and I can open them on OS X and Office 365. How can I recreate the error you see?

[Ziv-Barber]

My version not passing the last chats test (line).
In addition to that all the charts based pptx files are invalid.
The problem is the charts.xml file.
It has elements like "#list" and Office doesn't like it...

Ziv

On Wed, Sep 28, 2016 at 3:40 PM, Pieter Sheth-Voss <[email protected]

wrote:

Hi @Ziv-Barber https://github.com/Ziv-Barber This is a very useful
package, thank you again for creating and supporting it. Would definitely
like this to be easy on your side.

With the version I have am able to run npm run test, the various chart
files (e.g. open "/tmp/test-ppt-chart0.pptx") and they pass the
comparisons and I can open them on OS X and Office 365. How can I recreate
the error you see?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#83 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADf3MWnkKH10t6Nt9-B27OA36dTVhp8Kks5qum5RgaJpZM4GPqFP
.

[pietersv]

@Ziv-Barber Thanks. These seems open fine for me. Can you attach one or more here or email me directly? Also, any hints like OS would be helpful. The <#list> thing seems like an issue with converting the json to xml.