Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart support for powerpoint slide #17

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add chart support for powerpoint slide #17

wants to merge 22 commits into from

Conversation

vtloc
Copy link

@vtloc vtloc commented Jan 12, 2014

The following part is a bit tricky:

  • Currently, I wrote temporary excel files for embedding. Should use embedding document, but not enough time to do that. So I used msexcel-build instead.
  • Not yet to customize the chart's style. But I can keep working on this feature.

@Ziv-Barber
Copy link
Owner

WOW....
I started to work on that feature but I had a problem with embedding Excel
files which not always working.
I'll take me some time to work on this patch.

Ziv

On Sun, Jan 12, 2014 at 4:40 AM, vtloc [email protected] wrote:

The following part is a bit tricky:

  • Currently, I wrote temporary excel files for embedding. Should use
    embedding document, but not enough time to do that. So I used msexcel-build
    instead.
  • Not yet to customize the chart's style. But I can keep working on
    this feature.

You can merge this Pull Request by running

git pull https://github.com/vtloc/officegen master

Or view, comment on, or merge it at:

#17
Commit Summary

  • Add function for chart generation
  • - Support piechart, column chart
  • Fix sample,
  • Upgrade msexcel-builder.js module. Support exporting using number
    format.
  • Support bar chart
  • Remove temporatory files after generated.
  • Remove excel builder from list of modules.
  • Replace the way we calculate the path.
  • update the README
  • Update author info.
  • Increase version.
  • Edit the history and version.

File Changes

Patch Links:

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/17
.

@vtloc
Copy link
Author

vtloc commented Jan 13, 2014

Yup, took sometimes to understand the right way. Have yet to find a good way for debugging as it's really time-consuming debugging by comparing by hand.

Still, I planned to spend sometimes working on this module. Please feel free to ask if my code needs any more clarification or comments.

-Loc-

fix asynchronous call.
446dbc2 
modify the example to reflect new changes.
@zetaerre
Copy link

Hi Ziv,

i'm interested to use your library but don't see any load template function. Did you mind will be implemented ?

Thanks
r.

@protobi
Copy link
Contributor

protobi commented Jan 8, 2015

The @vtloc fork to generate PPT charts is extremely useful. It works fine. I did have to clone the code and run npm install to get it to work, but generating and embedding the temporary Excel files works fine on that fork. (Minor note, write those to the directory /tmp rather than /tmp let it work on Heroku too)

The main branch has evolved since January, so I spent some time trying to merge those changes into the main branch, but had difficulty. I cloned the main branch and manually copied the key sections from the @vtloc fork. However, try as I might it didn't quite seem to generate the temporary xlsx files correctly in the main branch. They generated but were invalid, and didn't get deleted. So set that aside for now.

Would be great to see this merged in. If that happens, there are additional extensions I'd like to contribute. Specifically, the PowerPoint charts are generated from hardcoded XML strings. That works fine, but it's hard to customize the graphs. So I created a new branch in which the chart fragments are replaced by equivalent Javascript objects, which XMLBuilder will accept. That way an API customer can get a standard chart base (or provide their own) and modify it to specify chart axis titles, colors, number formats, etc, or anything else possible in the OpenXML standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vtloc @Ziv-Barber @zetaerre @protobi @nanthak @k0sukey