Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested with GHC 9.10.1 #91

Merged
merged 1 commit into from
May 29, 2024
Merged

Tested with GHC 9.10.1 #91

merged 1 commit into from
May 29, 2024

Conversation

asr
Copy link
Contributor

@asr asr commented May 27, 2024

I got the following error when compiling with GHC 9.10.1:

$ cabal update
$ cabal build document --with-compiler=ghc-9.10.1 --project-file=cabal_no_viewer.project

lib/Pdf/Core/Parsers/Object.hs:29:1: error: [GHC-66111] [-Wunused-imports, Werror=unused-imports]
    The import of ‘Data.List’ is redundant
      except perhaps to import instances from ‘Data.List’
    To import instances alone, use: import Data.List()
   |
29 | import Data.List
   | ^^^^^^^^^^^^^^^^

Let's see what the CI tests say.

@asr
Copy link
Contributor Author

asr commented May 27, 2024

CI is green. After merging, please make an Hackage release. Thanks!

@Yuras
Copy link
Owner

Yuras commented May 27, 2024

I'd prefer to avoid inline CPP because one will have to do the same each time Data.List is imported.

Looks like Data.List is imported here just for foldl', which is exported from Prelude since base-4.20. Can we export it from our custom prelude for earlier versions of base?

@asr
Copy link
Contributor Author

asr commented May 27, 2024

I'd prefer to avoid inline CPP because one will have to do the same each time Data.List is imported.

Looks like Data.List is imported here just for foldl', which is exported from Prelude since base-4.20. Can we export it from our custom prelude for earlier versions of base?

Good idea. Done!

@Yuras Yuras merged commit 8b9f226 into Yuras:master May 29, 2024
9 checks passed
@Yuras
Copy link
Owner

Yuras commented May 29, 2024

Thanks! I pushed core and document to hackage.

@asr
Copy link
Contributor Author

asr commented May 29, 2024

Thanks! I pushed core and document to hackage.

Great! Thanks!

@asr asr deleted the ghc-9.10.1 branch May 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants