添加 userId 到 PayOrderDO #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 22ba34868e3d222822bd714a151059f0ed8df26b)
YunaiV
reviewed
Jun 15, 2024
| @@ -28,6 +28,10 @@ public class PayOrderCreateReqDTO implements Serializable { | |||
| @NotEmpty(message = "用户 IP 不能为空") | |||
| private String userIp; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
userType 有必要记录么? 🤔
除了管理员使用管理端测试支付的时候会产生零星的几个交易订单以为, 其他的应该都是会员产生的了吧?
There was a problem hiding this comment.
现有业务如此，但是有可能 admin 卖租户套餐，类似这种业务哈。
...-biz/src/main/java/cn/iocoder/yudao/module/pay/controller/admin/order/vo/PayOrderBaseVO.java
Show resolved
Hide resolved
...z/src/main/java/cn/iocoder/yudao/module/pay/controller/admin/order/vo/PayOrderPageReqVO.java
Outdated
Show resolved
Hide resolved
...odule-pay-biz/src/main/java/cn/iocoder/yudao/module/pay/dal/dataobject/order/PayOrderDO.java
Outdated
Show resolved
Hide resolved
| @@ -88,14 +88,18 @@ public class PayOrderDO extends BaseDO { | |||
| private Integer channelFeePrice; | |||
| /** | |||
| * 支付状态 | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
🤔 这个是 IDEA 格式化代码的时候自动加上去的...
我手动删掉以后再执行格式代码又会加上, 确定要删掉么?
There was a problem hiding this comment.
去掉哈。
ps：代码不要批量格式化。。。最好是自己写出来，就是标准的哈。
|
@MentatBot can you review the pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
业务上经常需要通过用户 id 来进行支付订单的查询, 但目前只能通过用户 id 查询到交易 id, 再通过交易 id 来查询支付订单, 很麻烦.
NOTE: 需要同步修改未上传到 git 仓库的 sql 脚本.