feat : 최근 상품 코멘트 조회 api #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingjakeu
reviewed
Jul 12, 2023
| .where(productComment.valid.isTrue) | ||
| .orderBy(productComment.productCommentId.desc()) | ||
| .select(productDetailVOProjection()) | ||
| .limit(10) |
There was a problem hiding this comment.
이렇게 query에 조회 size 매직넘버 다는것보다, 메소드 파람으로 들고오는게 맞아보여요
productDetailVOProjection 보다 ProductComment로 뽑아내고
코멘트 도메인이 자주 쓰일거라 ProductComment에 조인된 애들 Lazy로 걸어 놓는게 나을거 맞을거 같아요. Product 쪽 참고
There was a problem hiding this comment.
쿼리 고치는김에, 무한 스크롤대비 offset 조회로 만들면 좋을듯
…-Team-1-BE into feature/geng/issue-56-recent-comment
gengminy
commented
Jul 13, 2023
Comment on lines
38
to
42
| @JoinColumn(name = "productId", referencedColumnName = "productId", insertable = false, updatable = false) | ||
| @JoinColumn(name = "memberId", referencedColumnName = "memberId", insertable = false, updatable = false) | ||
| val memberProductLikeMappingList: Set<MemberProductLikeMapping> = setOf() | ||
| ): BaseEntity(), Serializable |
There was a problem hiding this comment.
복합키로 테이블 가져오려면 Serializable 을 implement 해야한다는데 이 부분 괜찮을까요
There was a problem hiding this comment.
앗... 그럼 그냥 VO 처리해요.
그리고 OneToMany 가져가는 애들 편의를 위해 fetchJoin 처리 하자는거여서
ManyToOne 은 예전 형태로 해주세요... 원복처리 쏘리...
There was a problem hiding this comment.
넵 commentDetailVO 로 롤백할게요 😥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직
api/commentdomain/comment참고사항
ProductCommentLike작업 후 수정 가능성 있음