[FEATURE] #33-Product Detail UI 구현 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myung6024
force-pushed
the
feature/#33-implement-product-detail
branch
from
bb917fa
to
e0d43e0
Compare
jiwon2724
reviewed
Jul 4, 2023
| item.eventList.forEachIndexed { index, event -> | ||
| val eventView = ListItemEventBinding.inflate(LayoutInflater.from(binding.root.context), binding.root, false).apply { | ||
| tvEventDes.text = event.title | ||
| ivStoreIcon.load(item.imageUrl) |
There was a problem hiding this comment.
https://coil-kt.github.io/coil/getting_started/
coil 라이브러리 사용시 Application class에서 ImageLoaderFactory를 구현 안해줘도 괜찮을까요~?.?
load()확장함수는 내부적으로
val imageLoader = imageView.context.imageLoader
val request = ImageRequest.Builder(imageView.context)
.data("https://example.com/image.jpg")
.target(imageView)
.build()
imageLoader.enqueue(request)
위 코드를 실행하는데, ImageLoaderFactory 구현을 안하면 ImageLoader는 기본적으로 lazy하게 생성되는 것으로 알고있습니다!
제가 잘못 알고 있는 부분이 있다면 코멘트 남겨주시면 감사하겠습니답!!🙇🙇
There was a problem hiding this comment.
lazy하게 생성되어도 괜찮을 것 같아요~!
aurora32s
approved these changes
Jul 6, 2023
| tvThumbsUpPercent.text = "${item.upvoteRate}%" | ||
| tvThumbsDownPercent.text = "${item.downvoteRate}%" | ||
|
|
||
| vThumbsUpRate.updateLayoutParams<LinearLayout.LayoutParams> { |
There was a problem hiding this comment.
오. 이 방법 배워갑니다. 👍🏻
CustomView만 생각하고 있었는데, 이런 방법이 있었네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
figma : https://www.figma.com/file/NREeyZFNDZGUrPb0JUfIoX/%ED%8E%B8%EB%A6%AC-Design?node-id=364%3A2123&mode=dev