Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] #116 보관함 레이아웃 구현 #121

Merged
merged 13 commits into from
Oct 14, 2023
Merged

[UI] #116 보관함 레이아웃 구현 #121

merged 13 commits into from
Oct 14, 2023

Conversation

jiwon2724
Copy link
Member

참고사항

  • PR 사이즈 고려해서 XML 작업 먼저 진행했습니다~
  • 저번 회의 때 단일 리소스는 하드코딩으로 채택돼서 단일 값은 하드코딩으로 진행했습니다~
  • BottomSheet, Alert은 재활용 될 것 같아서 제외했습니다!
  • XML 이상하거나, 개선 필요한 부분 있으면 코멘트 부탁드리겠습니답!
  • 궁금한 사항 슬랙에 남겨 놓았습니다! 시간 괜찮으실 때 확인 부탁드려요~:wink:

📌 내용

  • 보관함에 사용되는 UI 관련 레이아웃을 구현합니다.
    image

🛠️ Done!

  • 보관함 레이아웃 구현
  • RecyclerView Item 구현
  • 보관함 Empty UI 구현

관련 Issue

#116

@jiwon2724 jiwon2724 added 🐦 정지원(AOS) 담당 개발자 - 정지원(안드로이드) 📱 UI labels Oct 10, 2023
@jiwon2724 jiwon2724 added this to the UI milestone Oct 10, 2023
@jiwon2724 jiwon2724 self-assigned this Oct 10, 2023
aurora32s
aurora32s reviewed Oct 14, 2023
View reviewed changes
Copy link
Contributor

@aurora32s aurora32s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 하였습니다. 수고하셨어요~ :-)

feature/storage/src/main/res/layout/activity_storage.xml Outdated Show resolved Hide resolved
aurora32s
aurora32s approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@aurora32s aurora32s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 사항 확인 완료

@jiwon2724 jiwon2724 merged commit 8fbb758 into dev Oct 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurora32s aurora32s aurora32s approved these changes

@myung6024 myung6024 Awaiting requested review from myung6024

Assignees

@jiwon2724 jiwon2724

Labels
🐦 정지원(AOS) 담당 개발자 - 정지원(안드로이드) 📱 UI
Projects
None yet
Milestone
UI
Development

Successfully merging this pull request may close these issues.
2 participants
@jiwon2724 @aurora32s