[BUG] #117 : 탐색 화면의 검색 조건이 초기화되는 이슈 수정 #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurora32s
changed the title
jiwon2724
reviewed
Oct 15, 2023
| override fun bindingFactory(): ActivityExploreActivityBinding = ActivityExploreActivityBinding.inflate(layoutInflater) | ||
|
|
||
| override fun initViews() { | ||
| println(exploreViewModel) | ||
| productViewModel |
There was a problem hiding this comment.
이렇게 ViewModel 하나만 있어도 괜찮나요~?.?
Comment on lines
+22
to
+23
| private val productViewModel: ProductViewModel by viewModels { ProductViewModel.ProductViewModelFactory(productRepository) } | ||
| private val mainViewModel: MainViewModel by viewModels { MainViewModel.MainViewModelFactory() } |
There was a problem hiding this comment.
궁금한게 있읍니다 ㅎㅎ by viewModels()로 하면 해당부분 ViewModelFactory 필요한 부분 일까요?.?
myung6024
reviewed
Oct 17, 2023
Comment on lines
+6
to
+8
| interface PageActivity { | ||
| fun moveToEvaluatePage() | ||
| } |
There was a problem hiding this comment.
요거 navigator 이용하면 되지 않나욤?
myung6024
reviewed
Oct 17, 2023
Comment on lines
+175
to
+183
| // private fun observeKeyword() { | ||
| // viewLifecycleOwner.lifecycleScope.launch { | ||
| // viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) { | ||
| // exploreViewModel.productSearchCondition.collect { | ||
| // productViewModel.setProductSearchCondition(it) | ||
| // } | ||
| // } | ||
| // } | ||
| // } |
myung6024
reviewed
Oct 17, 2023
| moveToConditionExplore = productSearchableViewModel::changeSortType, | ||
| moveToStoreExplore = productSearchableViewModel::changeStoreType | ||
| moveToConditionExplore = { | ||
| (requireActivity() as? PageActivity)?.moveToEvaluatePage() |
There was a problem hiding this comment.
as?로 체크할거면 activity 쓰는게 안전할 것 같아요~
myung6024
reviewed
Oct 17, 2023
| @@ -38,6 +44,7 @@ class HomeFragment : BaseFragment<FragmentHomeBinding>() { | |||
|
|
|||
| override fun initViews() { | |||
| binding.rvHome.adapter = homeAdapter | |||
| // productSearchableViewModel | |||
myung6024
reviewed
Oct 17, 2023
|
|
||
| override fun initViews() { | ||
| productViewModel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
🛠 해결 방법
[기존]
[수정]
MainActivity, ExploreActivity)에서 주입받고 ProductFragment에서는 이러한 ViewModel을 가져다 사용하도록 수정