feat:linelint -a Fix linting errors #11
gongna-aulinelint.yml
on: push
Check if all files end in newline
17s
Annotations
58 errors and 2 warnings
|
[golangci] tests/e2e/config/manager.go#L483:
tests/e2e/config/manager.go#L483
Error return value of `file.Truncate` is not checked (errcheck)
|
|
[golangci] parser/lexer_test.go#L188:
parser/lexer_test.go#L188
tests: TestscanString has malformed name: first letter after 'Test' must not be lowercase (govet)
|
|
[golangci] log/zap/logger.go#L154:
log/zap/logger.go#L154
Error return value of `l.Noticex` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L163:
log/zap/logger.go#L163
Error return value of `l.Warnx` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L172:
log/zap/logger.go#L172
Error return value of `l.Fatalx` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L181:
log/zap/logger.go#L181
Error return value of `l.Tracex` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L190:
log/zap/logger.go#L190
Error return value of `l.Debugx` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L244:
log/zap/logger.go#L244
Error return value of `l.logger.Sync` is not checked (errcheck)
|
|
[golangci] log/zap/logger_test.go#L46:
log/zap/logger_test.go#L46
Error return value of `l.Sync` is not checked (errcheck)
|
|
[golangci] log/zap/logger_test.go#L67:
log/zap/logger_test.go#L67
Error return value of `l.Sync` is not checked (errcheck)
|
|
[golangci] log/zap/syncer.go#L64:
log/zap/syncer.go#L64
Error return value of `l.Sync` is not checked (errcheck)
|
|
[golangci] log/zap/logger.go#L123:
log/zap/logger.go#L123
ineffectual assignment to resultLevel (ineffassign)
|
|
[golangci] tests/e2e/dml/dml_set.go#L135:
tests/e2e/dml/dml_set.go#L135
Error return value is not checked (errcheck)
|
|
[golangci] tests/e2e/dml/dml_set.go#L404:
tests/e2e/dml/dml_set.go#L404
Error return value of `e2eMgr.Clean` is not checked (errcheck)
|
|
[golangci] tests/e2e/dml/dml_set_invalid.go#L110:
tests/e2e/dml/dml_set_invalid.go#L110
Error return value of `e2eMgr.Clean` is not checked (errcheck)
|
|
[golangci] tests/e2e/dml/dml_set.go#L126:
tests/e2e/dml/dml_set.go#L126
ineffectual assignment to err (ineffassign)
|
|
[golangci] tests/e2e/dml/dml_set.go#L421:
tests/e2e/dml/dml_set.go#L421
ineffectual assignment to err (ineffassign)
|
|
[golangci] tests/e2e/dml/dml_set.go#L425:
tests/e2e/dml/dml_set.go#L425
SA4004: the surrounding loop is unconditionally terminated (staticcheck)
|
|
[golangci] tests/e2e/util/db.go#L472:
tests/e2e/util/db.go#L472
ineffectual assignment to col (ineffassign)
|
|
[golangci] tests/e2e/util/db.go#L479:
tests/e2e/util/db.go#L479
ineffectual assignment to col (ineffassign)
|
|
[golangci] tests/e2e/shard/kingshard_hash.go#L156:
tests/e2e/shard/kingshard_hash.go#L156
Error return value of `e2eMgr.Clean` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L32:
mysql/variables_test.go#L32
Error return value of `dst.Set` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L67:
mysql/variables_test.go#L67
Error return value of `s.Set` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L104:
mysql/variables_test.go#L104
Error return value of `s.Set` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L105:
mysql/variables_test.go#L105
Error return value of `dst.Set` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L138:
mysql/variables_test.go#L138
Error return value of `s.Set` is not checked (errcheck)
|
|
[golangci] mysql/variables_test.go#L142:
mysql/variables_test.go#L142
Error return value of `dst.Set` is not checked (errcheck)
|
|
[golangci] mysql/error_test.go#L78:
mysql/error_test.go#L78
S1034: assigning the result of this type assertion to a variable (switch err := err.(type)) could eliminate type assertions in switch cases (gosimple)
|
|
[golangci] mysql/error_test.go#L81:
mysql/error_test.go#L81
S1034(related information): could eliminate this type assertion (gosimple)
|
|
[golangci] mysql/error_test.go#L83:
mysql/error_test.go#L83
S1034(related information): could eliminate this type assertion (gosimple)
|
|
[golangci] mysql/error_test.go#L85:
mysql/error_test.go#L85
S1034(related information): could eliminate this type assertion (gosimple)
|
|
[golangci] mysql/conn.go#L585:
mysql/conn.go#L585
ineffectual assignment to pos (ineffassign)
|
|
[golangci] log/xlog/util.go#L116:
log/xlog/util.go#L116
S1007: should use raw string (`...`) with regexp.Compile to avoid having to escape twice (gosimple)
|
|
[golangci] log/xlog/util.go#L114:
log/xlog/util.go#L114
SA1024: cutset contains duplicate characters (staticcheck)
|
|
[golangci] proxy/plan/merge_result.go#L136:
proxy/plan/merge_result.go#L136
field `extra` is unused (unused)
|
|
[golangci] proxy/server/client_conn.go#L374:
proxy/server/client_conn.go#L374
func `(*ClientConn).writeFields` is unused (unused)
|
|
[golangci] proxy/server/client_conn.go#L393:
proxy/server/client_conn.go#L393
func `(*ClientConn).writeEndResult` is unused (unused)
|
|
[golangci] proxy/server/executor_test.go#L736:
proxy/server/executor_test.go#L736
field `mysqlVersion` is unused (unused)
|
|
[golangci] proxy/server/executor_test.go#L1197:
proxy/server/executor_test.go#L1197
field `name` is unused (unused)
|
|
[golangci] proxy/plan/plan_unshard.go#L85:
proxy/plan/plan_unshard.go#L85
S1008: should use 'return ok' instead of 'if !ok { return false }; return true' (gosimple)
|
|
[golangci] proxy/server/session.go#L164:
proxy/server/session.go#L164
S1002: should omit comparison to bool constant, can be simplified to `!allowConnect` (gosimple)
|
|
[golangci] backend/slice.go#L575:
backend/slice.go#L575
S1034: assigning the result of this type assertion to a variable (switch col := col.(type)) could eliminate type assertions in switch cases (gosimple)
|
|
[golangci] backend/slice.go#L582:
backend/slice.go#L582
S1034: assigning the result of this type assertion to a variable (switch col := col.(type)) could eliminate type assertions in switch cases (gosimple)
|
|
[golangci] backend/slice.go#L589:
backend/slice.go#L589
S1034: assigning the result of this type assertion to a variable (switch col := col.(type)) could eliminate type assertions in switch cases (gosimple)
|
|
[golangci] proxy/server/session.go#L367:
proxy/server/session.go#L367
S1034: assigning the result of this type assertion to a variable (switch rs := rs.(type)) could eliminate type assertions in switch cases (gosimple)
|
|
[golangci] util/resource_pool_test.go#L698:
util/resource_pool_test.go#L698
lostcancel: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak (govet)
|
|
[golangci] proxy/plan/plan.go#L574:
proxy/plan/plan.go#L574
ineffectual assignment to sliceSQLs (ineffassign)
|
|
[golangci] proxy/server/executor_handle.go#L333:
proxy/server/executor_handle.go#L333
ineffectual assignment to ruleDB (ineffassign)
|
|
[golangci] proxy/server/executor_handle.go#L334:
proxy/server/executor_handle.go#L334
ineffectual assignment to isUnshardPlan (ineffassign)
|
|
[golangci] backend/connection_pool.go#L354:
backend/connection_pool.go#L354
SA5011: possible nil pointer dereference (staticcheck)
|
|
[golangci] backend/connection_pool.go#L356:
backend/connection_pool.go#L356
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
|
|
[golangci] backend/connection_pool.go#L355:
backend/connection_pool.go#L355
SA5011: possible nil pointer dereference (staticcheck)
|
|
[golangci] backend/connection_pool.go#L364:
backend/connection_pool.go#L364
SA5011: possible nil pointer dereference (staticcheck)
|
|
[golangci] backend/connection_pool.go#L366:
backend/connection_pool.go#L366
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
|
|
[golangci] backend/slice.go#L69:
backend/slice.go#L69
SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
|
|
[golangci] proxy/server/session_test.go#L174:
proxy/server/session_test.go#L174
SA2000: should call g.Add(1) before starting the goroutine to avoid a race (staticcheck)
|
|
[golangci] tests/e2e/function/prepare_stmt.go#L122:
tests/e2e/function/prepare_stmt.go#L122
SA5001: should check returned error before deferring rows.Close() (staticcheck)
|
|
[golangci] proxy/plan/plan_unshard_test.go#L95:
proxy/plan/plan_unshard_test.go#L95
SA4006: this value of `p` is never used (staticcheck)
|
|
Check if all files end in newline
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Check if all files end in newline
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|