Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenXDK XAudio in XQEMU #286

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

JayFoxRox
Copy link
Member

OpenXDK XAudio actually contains some code that probably doesn't conform with AC97.
It still works on hardware, but it doesn't work in XQEMU.

This PR fixes that, so that audio works in XQEMU.

I also have an explanation and a patch for XQEMU in JayFoxRox/xqemu#41 (including reasons as to why I don't intend to upstream it).

The primary motivation for this change is to make it more standard, and also to make it easier to test in XQEMU.

I have not tested this patch on hardware yet.

@thrimbor
Copy link
Member

thrimbor commented Feb 6, 2020

I tested this in XQEMU and on my Xbox. I came across another issue in the code (PRed in #294), and while it still works on my Xbox, the changes seem to have no effect on my XQEMU, I still get no audio (I'm still using Audio PR #3, and I have audio during the BIOS boot).

@dracc
Copy link
Contributor

dracc commented Feb 6, 2020

Works for me (I get audio) with XQEMU 0ced417e73.

Screenshot with patch:

Screenshot

Confirmed as silent/nonworking without this patch.
Screenshot without patch:

Screenshot

@thrimbor
Copy link
Member

thrimbor commented Feb 7, 2020

Alright, re-tested on xqemu master, and it works just fine. Merging.

@thrimbor thrimbor merged commit c48966b into XboxDev:master Feb 7, 2020
@JayFoxRox JayFoxRox deleted the fix-xqemu-audio branch February 7, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants