Remove legacy code #3838
Merged
Remove legacy code #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clear legacy proto field * Fix missing * Unify protocolname * Test remove * Supressor * Weird code
|
Thanks! Looks good to me. It seems transport DI should use RegisterProtocolConfigCreator() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要移除 transport 中已经标记过时的代码，现在对 transport 配置的处理代码仅剩余新路径，同时注册新的 transport 不需要再改动
transport/internet/config.proto，彻底使用string。以上改动主要在
transport/internet/中。（并且升级了一批测试，调整 transport 名字的存放位置）至此目前已经明确标记为弃用并且已经迁移的内容大体上清理完成。
次要改动：
话说对 transport 初始化的时候使用
common.RegisterConfig()是必须/更好还是看起来是个手误？似乎移除之后不影响一般正常使用。