Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1655: Added missing kinds #149

Merged
merged 1 commit into from
Sep 24, 2024
Merged

FEDX-1655: Added missing kinds #149

merged 1 commit into from
Sep 24, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Sep 24, 2024

FEDX-1655

Issue Status

Now that sourcegraph/scip#277 merged, we can leverage the new kind fields to record missing Extension and Mixing types

QA

  • Verify that extensions and mixins contain the expected kind ids (via scip print)

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@bender-wk bender-wk changed the title Added missing kinds FEDX-1655: Added missing kinds Sep 24, 2024
@matthewnitschke-wk matthewnitschke-wk requested a review from a team September 24, 2024 15:24
@alanknight-wk
Copy link

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 399a8c7 into master Sep 24, 2024
23 of 24 checks passed
@rmconsole4-wk rmconsole4-wk deleted the added_missing_kinds branch September 24, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants