End the ungodly racket made by PHP deprecation warnings #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I628886a39b2a0c540761cbf228ee2fdfad8de2e6
…ubject) of type array|string is deprecated" Change-Id: I0781b40459109b0e16af90f87bb83a797777c29c
Bug: T358843 Change-Id: I8c0daa6f07bc15b5fcf3fdb28f39a7fd86a16402
Null check the query, since it may be absent. Bug: T356568 Change-Id: I1d24365c6c3492d8b9b7e9be2d37295199bc53c9
Bug: T341408 Change-Id: Iccde6f6137f389b01db28f78acb4f92ee129cd61
maaartyyynaa
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our version of Cargo is missing several PHP > 8.1 compatibility patches, which causes it to emit a significant amount of deprecation notices. This is especially noticeable and annoying on devboxes, where these spawn giant XDebug error boxes and interfere with testing. So, backport the relevant fixes to silence the logs.