Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLATFORM-9707 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PLATFORM-9707 #2

wants to merge 3 commits into from

Conversation

adpaste
Copy link
Member

@adpaste adpaste commented Sep 26, 2024

@mmeller-wikia
Copy link

Note: This change will break PR check https://github.com/Wikia/gifsicle/actions/runs/11047685551/job/30689401792?pr=2

> Run autoreconf -i
configure.ac:3: error: Autoconf version 2.72 or higher is required
configure.ac:3: the top level
autom4te: error: /usr/bin/m4 failed with exit status: [6](https://github.com/Wikia/gifsicle/actions/runs/11047685551/job/30689401792?pr=2#step:3:7)3
aclocal: error: /usr/bin/autom4te failed with exit status: 63
autoreconf: error: aclocal failed with exit status: 63

Suggestion: We might cherry-pick kohler@d60b5e5 to fix that and simplify Gifsicle dockerfile in Thumblr

@kohler @adpaste
Reduce AC_PREREQ.
594f7d7 
(cherry picked from commit d60b5e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeller-wikia mmeller-wikia mmeller-wikia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adpaste @mmeller-wikia @kohler