Skip to content

Commit

Permalink
Merge pull request #16 from Wikia/unify_metrics
Browse files Browse the repository at this point in the history
Unify http requests total metric name
  • Loading branch information
harnash authored Sep 3, 2024
2 parents c6c15b1 + f88c596 commit 0ae2f7d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion otel-meter.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func New(config MiddlewareConfig) *Metrics {
// the result name is `requests_total`
// https://github.com/open-telemetry/opentelemetry-go/blob/46f2ce5ca6adaa264c37cdbba251c9184a06ed7f/exporters/prometheus/exporter.go#L74
// the exporter will enforce the `_total` suffix for counter, so we do not need it here
"requests",
"http.requests",
// see https://github.com/open-telemetry/opentelemetry-go/pull/3776
// The go.opentelemetry.io/otel/metric/unit package is deprecated. Setup the equivalent unit string instead. (#3776)
// Setup "1" instead of unit.Dimensionless
Expand Down

0 comments on commit 0ae2f7d

Please sign in to comment.