Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename image dump bug for Gamepedia API #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Elaeagnifolia
Copy link

@Elaeagnifolia Elaeagnifolia commented Nov 9, 2020

Gamepedia's image files were moved to Wikia's image servers, so dumping images with the script - given a Gamepedia API - causes the same latest?cb= filename bug that Wikia/Fandom Wikis experienced (Issue #336).

Example:
https://dragalialost.gamepedia.com/File:Notte.png
https://static.wikia.nocookie.net/dragalialost_gamepedia_en/images/e/e8/Notte.png/revision/latest?cb=20180919220831

Gamepedia's image files were moved to Wikia's image servers, so dumping images with the script - given a Gamepedia API - causes the same latest?cb= filename bug that Wikia/Fandom Wikis experienced (Issue WikiTeam#362).

Example: 
https://dragalialost.gamepedia.com/File:Notte.png
https://static.wikia.nocookie.net/dragalialost_gamepedia_en/images/e/e8/Notte.png/revision/latest?cb=20180919220831
@nemobis
Copy link
Member

nemobis commented Nov 16, 2020

Sorry for not replying, but I understood that Gamepedia is currently busy moving chairs around, isn't it? Do you think the situation is already stable enough?
https://community.fandom.com/wiki/User_blog:MisterWoodhouse/The_Future_of_Gamepedia

@Elaeagnifolia
Copy link
Author

Sorry if I misunderstood, but yes, the Gamepedia brand will transition to Fandom in ~2 months I believe, so I expect the move to Wikia's file servers to be permanent as they prep for that transition.

I suppose when the brand change does happen, then this PR will resolve itself since the API URL should be reflected as a Fandom domain. But until then, this PR fixes the issue with saving Gamepedia images for those looking to dump now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants