Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerHub release workflows broken #104

Closed
benfrancis opened this issue Sep 30, 2024 · 4 comments · Fixed by #105
Closed

DockerHub release workflows broken #104

benfrancis opened this issue Sep 30, 2024 · 4 comments · Fixed by #105
Labels

Comments

@benfrancis
Copy link
Member

DockerHub now requires a personal access token instead of a password

Error response from daemon: Get "https://registry-1.docker.io/v2/": unauthorized: your account must log in with a Personal Access Token (PAT) - learn more at docs.docker.com/go/access-tokens
Error: Command failed: docker_buildx/scripts/docker_login.sh *** *** 
@benfrancis
Copy link
Member Author

@tim-hellhake I tried to fix this with #105 by replacing password with a personal access token as we did with WebThingsIO/addon-builder@13f94eb#diff-6e17565eb21d66eba4e808cded354e8dd1ec2f5c580ab6632c708acb2d2c509fR45

Unfortunately the workflow still fails with the error "Error: The parameter dockerPassword is missing". so it requires a bit more investigation. If the current GitHub action doesn't support personal access tokens we may have to switch to a newer workflow. See https://docs.docker.com/build/ci/github-actions/

I will try to take another look tomorrow but if you get a chance sooner then please do because I am expecting outgoing email to stop working for the webthings.io registration server at some point today.

@tim-hellhake
Copy link
Member

@benfrancis it fails because there no secret called DOCKER_HUB_PAT present in this repository.
You can add it here: https://github.com/WebThingsIO/registration_server/settings/secrets/actions.
It's also possible to set the secret in the scope of the organisation: https://github.com/organizations/WebThingsIO/settings/secrets/actions

@benfrancis
Copy link
Member Author

🤦 thanks! I've updated the username and personal access token secrets in the repository.

The release workflow is now failing with a new error:

2.613 E: The repository 'http://deb.debian.org/debian buster-backports Release' does not have a Release file.

I have proposed a temporary fix for this error in #106

@benfrancis
Copy link
Member Author

Fixed by #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants