CompositorBufferType: EventFrame should be 64bit also on 32bit #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramoosterhuis
force-pushed
the
fix/CompositorBuffer--EventFrame-should-be-64bit-also-on-32bit
branch
3 times, most recently
from
5b17188
to
e2c7a5b
Compare
bramoosterhuis
requested review from
MFransen69
and removed request for
pwielders
MFransen69
requested changes
Jan 17, 2024
| , _modifier(0) | ||
| , _type(Exchange::ICompositionBuffer::TYPE_INVALID) | ||
| , _dirty() | ||
| , _copyOfDirty() |
There was a problem hiding this comment.
Better to explicitly set it to a value for clarity (at the moment it would be false I assume)
bramoosterhuis
force-pushed
the
fix/CompositorBuffer--EventFrame-should-be-64bit-also-on-32bit
branch
from
4278204
to
e688d9b
Compare
MFransen69
approved these changes
Jan 17, 2024
…4bit-also-on-32bit
bramoosterhuis
deleted the
fix/CompositorBuffer--EventFrame-should-be-64bit-also-on-32bit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see:
https://github.com/torvalds/linux/blob/v6.1/fs/eventfd.c#L275