Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multiple initial fields support #508

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Add Multiple initial fields support #508

merged 9 commits into from
Oct 3, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves #505

@vitPinchuk vitPinchuk self-assigned this Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (91b24fb) to head (2264a8f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         116      116           
  Lines        1956     1963    +7     
  Branches      480      524   +44     
=======================================
+ Hits         1939     1946    +7     
  Misses         15       15           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Oct 3, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.7.0 milestone Oct 3, 2024
@vitPinchuk vitPinchuk marked this pull request as draft October 3, 2024 06:05
@vitPinchuk vitPinchuk marked this pull request as ready for review October 3, 2024 08:39
asimonok
asimonok approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 105106e into main Oct 3, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/multiple-initial-fields branch October 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.7.0
Development

Successfully merging this pull request may close these issues.

Multiple initial fields from query source cannot be distinguished
3 participants
@vitPinchuk @asimonok @mikhail-vl