Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom input for Select, Multi select #507

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #503

@vitPinchuk vitPinchuk self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (4ee439b) to head (dc8a005).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   99.12%   99.13%           
=======================================
  Files         116      116           
  Lines        1946     1956   +10     
  Branches      476      480    +4     
=======================================
+ Hits         1929     1939   +10     
  Misses         15       15           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Oct 2, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.7.0 milestone Oct 2, 2024
src/types/form-element.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 91b24fb into main Oct 3, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/custom-input branch October 3, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Multi select with custom input
3 participants