Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom color/background color for elements #386

Merged
merged 17 commits into from
Jun 26, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #373
Allow add background color for element/label;
Allow add color for label;

@vitPinchuk vitPinchuk requested a review from asimonok April 9, 2024 16:19
@vitPinchuk vitPinchuk self-assigned this Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (0e17e05) to head (8b30b19).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   99.11%   99.13%   +0.01%     
==========================================
  Files          72       72              
  Lines        1590     1616      +26     
  Branches      429      443      +14     
==========================================
+ Hits         1576     1602      +26     
  Misses         12       12              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Apr 18, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with ColorPicker and add a clear button

@mikhail-vl mikhail-vl added this to the Version 3.8.0 milestone Apr 23, 2024
@vitPinchuk
Copy link
Contributor Author

@asimonok I added ColorPicker and a clear buttons

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 9600532 into main Jun 26, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/color-background-color-for-elements branch June 26, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding custom color/background color for elements
3 participants