Skip to content

Commit

Permalink
Remove unnecessary test id for time input
Browse files Browse the repository at this point in the history
  • Loading branch information
asimonok committed Apr 22, 2024
1 parent aaa354b commit f3b9598
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions src/components/FormElement/FormElement.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,9 @@ export const FormElement: React.FC<Props> = ({ element, onChange, highlightClass
transparent={!element.title}
disabled={element.disabled}
className={styles.timeInputWrap}
data-testid={TEST_IDS.formElements.fieldTime}
>
<TimeOfDayPicker
data-testid={TEST_IDS.formElements.fieldTimeInput}
data-testid={TEST_IDS.formElements.fieldTime}
value={element.value ? dateTime(element.value) : dateTime(new Date().toISOString())}
onChange={(dateTime: DateTime) => {
onChange<typeof element>({
Expand Down
4 changes: 2 additions & 2 deletions src/components/FormElements/FormElements.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -853,12 +853,12 @@ describe('Form Elements', () => {
*/
render(getComponent({ options, onChangeElement }));

expect(selectors.fieldTimeInput()).toBeInTheDocument();
expect(selectors.fieldTime()).toBeInTheDocument();

/**
* Change date time
*/
await act(() => fireEvent.change(selectors.fieldTimeInput(), { target: { value: '2024-04-10T12:30:00Z' } }));
await act(() => fireEvent.change(selectors.fieldTime(), { target: { value: '2024-04-10T12:30:00Z' } }));

expect(onChangeElement).toHaveBeenCalledWith(
expect.objectContaining({
Expand Down
1 change: 0 additions & 1 deletion src/constants/tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export const TEST_IDS = {
*/
fieldDateTime: 'date-time-input',
fieldTime: 'data-testid form-elements field-time',
fieldTimeInput: 'data-testid form-elements field-time-input',
fieldSlider: 'form-elements field-slider',
fieldSliderInput: 'data-testid form-elements field-slider-input',
fieldRadioContainer: 'data-testid form-elements field-radio-container',
Expand Down

0 comments on commit f3b9598

Please sign in to comment.