Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promise libraries import #333

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Add promise libraries import #333

merged 5 commits into from
Sep 12, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Sep 11, 2024

Resolves #300
Resolves #302

@vitPinchuk vitPinchuk self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (5f45d67) to head (d05dfaf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   98.42%   98.55%   +0.13%     
==========================================
  Files          58       58              
  Lines         824      830       +6     
  Branches      130      151      +21     
==========================================
+ Hits          811      818       +7     
+ Misses         13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl self-requested a review September 11, 2024 10:08
@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 11, 2024
@mikhail-vl mikhail-vl added this to the Charts 6.4.0 milestone Sep 11, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Import support updated Add promise libraries import Sep 12, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit cf26144 into main Sep 12, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the fea/import-support-examples branch September 12, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ecSimpleTranform library Add import support similar to Business Text
3 participants