Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boxplot in Visual Editor #327

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Add Boxplot in Visual Editor #327

merged 5 commits into from
Sep 4, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #321

@vitPinchuk vitPinchuk self-assigned this Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (5f78c89) to head (5d9bd4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   98.25%   98.30%   +0.04%     
==========================================
  Files          52       54       +2     
  Lines         747      769      +22     
  Branches      122      124       +2     
==========================================
+ Hits          734      756      +22     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 2, 2024
@mikhail-vl mikhail-vl added this to the Charts 6.4.0 milestone Sep 2, 2024
@mikhail-vl mikhail-vl changed the title Boxplot in Visual Editor Add Boxplot in Visual Editor Sep 2, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitPinchuk Please provision botplot dashboard with example

@vitPinchuk
Copy link
Contributor Author

@mikhail-vl provision updated

We should definitely add a point to the documentation that when working with boxplot it is especially important to set the x,y axis correctly

image

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit fbfde85 into main Sep 4, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/boxplot-visual-editor branch September 4, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Boxplot example to use Visual Editor
3 participants